Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix determination of copyable layout for compressed textures in Vulkan #86855

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix determination of copyable layout for compressed textures in Vulkan #86855

merged 1 commit into from
Jan 15, 2024

Conversation

RandomShaper
Copy link
Member

Fixes #86628.

@RandomShaper RandomShaper added this to the 4.3 milestone Jan 5, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner January 5, 2024 23:06
@fire fire requested a review from a team January 7, 2024 01:05
@DarioSamo DarioSamo mentioned this pull request Jan 7, 2024
Merged
7 tasks
@clayjohn clayjohn mentioned this pull request Jan 12, 2024
Closed
clayjohn
clayjohn approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@akien-mga akien-mga merged commit 1248fb9 into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_vk_get_image branch January 15, 2024 15:12
@TokisanGames TokisanGames mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
Asset Pipeline Issue Triage
Status: Done
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Saving a VRAM Compressed image is broken in 4.3-dev after RenderingDevice refactor
3 participants
@RandomShaper @akien-mga @clayjohn